Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-13232 Fix SSL Mysql tests for PMM v3 #828

Open
wants to merge 14 commits into
base: v3
Choose a base branch
from
Open

PMM-13232 Fix SSL Mysql tests for PMM v3 #828

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d07996a
PMM-13232: Fix remote service name
peterSirotnak Jul 13, 2024
1ce3f67
PMM-13232: Fix remote service name
peterSirotnak Jul 13, 2024
03fc929
PMM-13232: Debug running containers
peterSirotnak Jul 14, 2024
6a50c69
PMM-13232: Fix certificate locators
peterSirotnak Jul 14, 2024
40d4e0e
PMM-13232: Fix service name
peterSirotnak Jul 14, 2024
216626d
PMM-13232: Test fixes
peterSirotnak Jul 14, 2024
d433c08
PMM-13232: Test fixes
peterSirotnak Jul 14, 2024
ca0b9d1
PMM-13232: fix finding mysqld exporter
peterSirotnak Jul 14, 2024
84d24a3
PMM-13232: Fix mysqld location
peterSirotnak Jul 14, 2024
d610387
PMM-13232: Skip running for 5.7
peterSirotnak Jul 14, 2024
9ce6d75
PMM-13232: Refactors tests
peterSirotnak Jul 18, 2024
6a4571f
PMM-13232: Refactors tests
peterSirotnak Jul 18, 2024
3f10126
Merge branch 'v3' into PMM-13232-fix-mysql-v3
peterSirotnak Jul 18, 2024
b207bb2
PMM-13232: Refactors tests
peterSirotnak Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 35 additions & 40 deletions tests/verifyTLSMySQLRemoteInstance_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,16 @@ maxQueryLengthTestData.add(['^']);
maxQueryLengthTestData.add(['`']);
maxQueryLengthTestData.add(['"']);

instances.add(['mysql_5.7_ssl_service', '5.7', 'mysql_5.7', 'mysql_ssl', 'mysql_global_status_max_used_connections']);
instances.add(['mysql_8.0_ssl_service', '8.0', 'mysql_8.0', 'mysql_ssl', 'mysql_global_status_max_used_connections']);

maxQueryLengthInstances.add(['mysql_5.7_ssl_service', '5.7', 'mysql_5.7', 'mysql_ssl', 'mysql_global_status_max_used_connections', '10']);
maxQueryLengthInstances.add(['mysql_5.7_ssl_service', '5.7', 'mysql_5.7', 'mysql_ssl', 'mysql_global_status_max_used_connections', '-1']);
maxQueryLengthInstances.add(['mysql_5.7_ssl_service', '5.7', 'mysql_5.7', 'mysql_ssl', 'mysql_global_status_max_used_connections', '']);
maxQueryLengthInstances.add(['mysql_8.0_ssl_service', '8.0', 'mysql_8.0', 'mysql_ssl', 'mysql_global_status_max_used_connections', '10']);
maxQueryLengthInstances.add(['mysql_8.0_ssl_service', '8.0', 'mysql_8.0', 'mysql_ssl', 'mysql_global_status_max_used_connections', '-1']);
maxQueryLengthInstances.add(['mysql_8.0_ssl_service', '8.0', 'mysql_8.0', 'mysql_ssl', 'mysql_global_status_max_used_connections', '']);

AfterSuite(async ({ I }) => {
await I.verifyCommand('docker stop mysql_5.7 || docker rm mysql_5.7');
await I.verifyCommand('docker stop mysql_8.0 || docker rm mysql_8.0');
});
instances.add(['mysql_8.0_ssl_service', '8.0', 'mysql_ssl_8.0', 'mysql_ssl', 'mysql_global_status_max_used_connections']);
// instances.add(['mysql_5.7_ssl_service', '5.7', 'mysql_ssl_5.7', 'mysql_ssl', 'mysql_global_status_max_used_connections']);


maxQueryLengthInstances.add(['mysql_8.0_ssl_service', '8.0', 'mysql_ssl_8.0', 'mysql_ssl', 'mysql_global_status_max_used_connections', '10']);
maxQueryLengthInstances.add(['mysql_8.0_ssl_service', '8.0', 'mysql_ssl_8.0', 'mysql_ssl', 'mysql_global_status_max_used_connections', '-1']);
maxQueryLengthInstances.add(['mysql_8.0_ssl_service', '8.0', 'mysql_ssl_8.0', 'mysql_ssl', 'mysql_global_status_max_used_connections', '']);
// maxQueryLengthInstances.add(['mysql_5.7_ssl_service', '5.7', 'mysql_ssl_5.7', 'mysql_ssl', 'mysql_global_status_max_used_connections', '10']);
// maxQueryLengthInstances.add(['mysql_5.7_ssl_service', '5.7', 'mysql_ssl_5.7', 'mysql_ssl', 'mysql_global_status_max_used_connections', '-1']);
// maxQueryLengthInstances.add(['mysql_5.7_ssl_service', '5.7', 'mysql_ssl_5.7', 'mysql_ssl', 'mysql_global_status_max_used_connections', '']);

Before(async ({ I, settingsAPI }) => {
await I.Authorize();
Expand All @@ -46,9 +42,6 @@ Data(instances).Scenario(
let details;
const remoteServiceName = `remote_${serviceName}_faker`;

await I.verifyCommand(`${pmmFrameworkLoader} --ps-version=${version} --setup-mysql-ssl --pmm2`);
await I.say(await I.verifyCommand(`docker exec ${container} bash -c 'source ~/.bash_profile || true; pmm-admin list'`));

if (serviceType === 'mysql_ssl') {
details = {
serviceName: remoteServiceName,
Expand All @@ -59,9 +52,9 @@ Data(instances).Scenario(
password: 'pmm',
cluster: 'mysql_remote_cluster',
environment: 'mysql_remote_cluster',
tlsCAFile: `${adminPage.pathToPMMTests}tls-ssl-setup/mysql/${version}/ca.pem`,
tlsKeyFile: `${adminPage.pathToPMMTests}tls-ssl-setup/mysql/${version}/client-key.pem`,
tlsCertFile: `${adminPage.pathToPMMTests}tls-ssl-setup/mysql/${version}/client-cert.pem`,
tlsCA: await I.verifyCommand(`docker exec ${container} cat /var/lib/mysql/ca.pem`),
tlsKey: await I.verifyCommand(`docker exec ${container} cat /var/lib/mysql/client-key.pem`),
tlsCert: await I.verifyCommand(`docker exec ${container} cat /var/lib/mysql/client-cert.pem`),
};
}

Expand All @@ -77,7 +70,7 @@ Data(instances).Scenario(
serviceType: 'MYSQL_SERVICE',
service: 'mysql',
},
serviceName,
remoteServiceName,
);

// Check Remote Instance also added and have running status
Expand All @@ -92,7 +85,7 @@ Data(instances).Scenario(
I, remoteInstancesPage, pmmInventoryPage, current, grafanaAPI,
}) => {
const {
serviceName, metric,
serviceName, metric, container,
} = current;
let response; let result;
const remoteServiceName = `remote_${serviceName}_faker`;
Expand All @@ -101,10 +94,12 @@ Data(instances).Scenario(
I.wait(10);

// verify metric for client container node instance
response = await grafanaAPI.checkMetricExist(metric, { type: 'service_name', value: serviceName });
const localServiceName = await I.verifyCommand(`docker exec ${container} pmm-admin list | grep "MySQL" | grep "ssl_service" | awk -F " " '{print $2}'`);

response = await grafanaAPI.checkMetricExist(metric, { type: 'service_name', value: localServiceName });
result = JSON.stringify(response.data.data.result);

assert.ok(response.data.data.result.length !== 0, `Metrics ${metric} from ${serviceName} should be available but got empty ${result}`);
assert.ok(response.data.data.result.length !== 0, `Metrics ${metric} from ${localServiceName} should be available but got empty ${result}`);

// verify metric for remote instance
response = await grafanaAPI.checkMetricExist(metric, { type: 'service_name', value: remoteServiceName });
Expand Down Expand Up @@ -141,7 +136,6 @@ Data(instances).Scenario(
},
).retry(1);


Data(instances).Scenario(
'Verify dashboard after MySQL SSL Instances are added @ssl @ssl-mysql @ssl-remote @not-ui-pipeline',
async ({
Expand All @@ -161,8 +155,7 @@ Data(instances).Scenario(
adminPage.performPageDown(5);
await dashboardPage.expandEachDashboardRow();
adminPage.performPageUp(5);
await dashboardPage.verifyThereAreNoGraphsWithNA();
await dashboardPage.verifyThereAreNoGraphsWithoutData(1);
await dashboardPage.verifyThereAreNoGraphsWithoutData(12);
}
},
).retry(2);
Expand All @@ -173,17 +166,19 @@ Data(instances).Scenario(
I, queryAnalyticsPage, current, adminPage,
}) => {
const {
serviceName,
serviceName, container,
} = current;

const serviceList = [serviceName, `remote_${serviceName}_faker`];
const localServiceName = await I.verifyCommand(`docker exec ${container} pmm-admin list | grep "MySQL" | grep "ssl_service" | awk -F " " '{print $2}'`);

const serviceList = [localServiceName, `remote_${serviceName}_faker`];

for (const service of serviceList) {
I.amOnPage(I.buildUrlWithParams(queryAnalyticsPage.url, { from: 'now-5m' }));
queryAnalyticsPage.waitForLoaded();
await adminPage.applyTimeRange('Last 12 hours');
queryAnalyticsPage.waitForLoaded();
await queryAnalyticsPage.filters.selectFilter(service);
await queryAnalyticsPage.filters.selectFilterInGroup(service, 'Service Name');
queryAnalyticsPage.waitForLoaded();
const count = await queryAnalyticsPage.data.getCountOfItems();

Expand All @@ -205,14 +200,14 @@ Data(instances).Scenario(

const agent_id = await I.verifyCommand(`docker exec ${container} pmm-admin list | grep mysqld_exporter | awk -F" " '{print $4}' | awk -F"/" '{print $3}'`);

await I.verifyCommand(`docker exec ${container} ls -la /usr/local/percona/pmm2/tmp/mysqld_exporter/agent_id/${agent_id}/ | grep tls`);
await I.verifyCommand(`docker exec ${container} rm -r /usr/local/percona/pmm2/tmp/mysqld_exporter/`);
await I.verifyCommand(`docker exec ${container} ls -la /usr/local/percona/pmm2/tmp/mysqld_exporter/`, 'ls: cannot access \'/usr/local/percona/pmm2/tmp/mysqld_exporter\': No such file or directory', 'fail');
await I.verifyCommand(`docker exec ${container} ls -la /usr/local/percona/pmm/tmp/mysqld_exporter/agent_id/${agent_id}/ | grep tls`);
await I.verifyCommand(`docker exec ${container} rm -r /usr/local/percona/pmm/tmp/mysqld_exporter/`);
await I.verifyCommand(`docker exec ${container} ls -la /usr/local/percona/pmm/tmp/mysqld_exporter/`, 'ls: cannot access \'/usr/local/percona/pmm2/tmp/mysqld_exporter\': No such file or directory', 'fail');
await I.verifyCommand(`docker exec ${container} pmm-admin list | grep mysqld_exporter | grep Running`);
await I.verifyCommand(`docker exec ${container} pkill -f mysqld_exporter`);
I.wait(10);
await I.verifyCommand(`docker exec ${container} pmm-admin list | grep mysqld_exporter | grep Running`);
await I.verifyCommand(`docker exec ${container} ls -la /usr/local/percona/pmm2/tmp/mysqld_exporter/agent_id/${agent_id}/ | grep tls`);
await I.verifyCommand(`docker exec ${container} ls -la /usr/local/percona/pmm/tmp/mysqld_exporter/agent_id/${agent_id}/ | grep tls`);
},
).retry(1);

Expand Down Expand Up @@ -255,9 +250,9 @@ Data(maxQueryLengthInstances).Scenario(
password: 'pmm',
cluster: 'mysql_remote_cluster',
environment: 'mysql_remote_cluster',
tlsCAFile: `${adminPage.pathToPMMTests}tls-ssl-setup/mysql/${version}/ca.pem`,
tlsKeyFile: `${adminPage.pathToPMMTests}tls-ssl-setup/mysql/${version}/client-key.pem`,
tlsCertFile: `${adminPage.pathToPMMTests}tls-ssl-setup/mysql/${version}/client-cert.pem`,
tlsCA: await I.verifyCommand(`docker exec ${container} cat /var/lib/mysql/ca.pem`),
tlsKey: await I.verifyCommand(`docker exec ${container} cat /var/lib/mysql/client-key.pem`),
tlsCert: await I.verifyCommand(`docker exec ${container} cat /var/lib/mysql/client-cert.pem`),
};
}

Expand All @@ -276,7 +271,7 @@ Data(maxQueryLengthInstances).Scenario(
serviceType: 'MYSQL_SERVICE',
service: 'mysql',
},
serviceName,
remoteServiceName,
);

const { service_id } = await inventoryAPI.apiGetNodeInfoByServiceName('MYSQL_SERVICE', remoteServiceName);
Expand All @@ -292,9 +287,9 @@ Data(maxQueryLengthInstances).Scenario(
// Check max visible query length is less than max_query_length option
I.amOnPage(I.buildUrlWithParams(queryAnalyticsPage.url, { from: 'now-5m' }));
queryAnalyticsPage.waitForLoaded();
await queryAnalyticsPage.filters.selectFilter(remoteServiceName);
await queryAnalyticsPage.filters.selectFilterInGroup(remoteServiceName, 'Service Name');
I.waitForElement(queryAnalyticsPage.data.elements.queryRows, 30);
const queryFromRow = await queryAnalyticsPage.data.elements.queryRowValue(1);
const queryFromRow = await I.grabTextFrom(await queryAnalyticsPage.data.elements.queryRowValue(1));

if (maxQueryLength !== '' && maxQueryLength !== '-1') {
assert.ok(queryFromRow.length <= maxQueryLength, `Query length exceeds max length boundary equals ${queryFromRow.length} is more than ${maxQueryLength}`);
Expand Down
Loading