Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13658: support failed precondition status #3457

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Conversation

idoqo
Copy link
Contributor

@idoqo idoqo commented Jan 15, 2025

PMM-13658

Link to the Feature Build: SUBMODULES-3818

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

@idoqo idoqo requested a review from a team as a code owner January 15, 2025 07:40
@idoqo idoqo requested review from BupycHuk and JiriCtvrtka and removed request for a team January 15, 2025 07:40
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 43.60%. Comparing base (5e69f01) to head (b698ce9).

Files with missing lines Patch % Lines
managed/services/server/updater.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3457      +/-   ##
==========================================
- Coverage   43.61%   43.60%   -0.01%     
==========================================
  Files         366      366              
  Lines       44258    44259       +1     
==========================================
- Hits        19302    19300       -2     
- Misses      23274    23278       +4     
+ Partials     1682     1681       -1     
Flag Coverage Δ
managed 45.35% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff merged commit bbc5c8a into v3 Jan 17, 2025
6 of 8 checks passed
@ademidoff ademidoff deleted the PMM-13658-server-error branch January 17, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants