Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allwinner: Added support for allwinner H616 processor #58

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

didiercrunch
Copy link

Added support for the allwinner H616 processor. Apparently, this also works for H618 processor.

Helps with #57 but doesn't not completely fix it.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution!

I see a few failures unrelated to your change on the CI, I'll take a look to try to fix these. The PR will fail for the license header check at least, so you'll want to fix that.
A few changes requested, nothing significant.

allwinner/address_test.go Outdated Show resolved Hide resolved
allwinner/address_test.go Outdated Show resolved Hide resolved
allwinner/address_test.go Outdated Show resolved Hide resolved
allwinner/address_test.go Outdated Show resolved Hide resolved
allwinner/h6.go Outdated Show resolved Hide resolved
allwinner/h6.go Outdated Show resolved Hide resolved
allwinner/h6.go Show resolved Hide resolved
@maruel
Copy link
Member

maruel commented Aug 9, 2024

I fixed the checks on origin/main, can you rebase and push again? Thanks!

@didiercrunch
Copy link
Author

I fixed the checks on origin/main, can you rebase and push again? Thanks!

done

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you figure out why the checks still fail? Do you want help with diagnosing the problem?

allwinner/h6_test.go Show resolved Hide resolved
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 36.26374% with 58 lines in your changes missing coverage. Please review.

Project coverage is 28.2%. Comparing base (50d4ed0) to head (4abefc9).

Files with missing lines Patch % Lines
allwinner/address.go 54.7% 14 Missing and 10 partials ⚠️
allwinner/h6.go 17.4% 19 Missing ⚠️
allwinner/gpio.go 0.0% 9 Missing ⚠️
allwinner/detect.go 0.0% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #58     +/-   ##
=======================================
+ Coverage   27.4%   28.2%   +0.8%     
=======================================
  Files         89      91      +2     
  Lines      11011    8915   -2096     
=======================================
- Hits        3014    2511    -503     
+ Misses      7864    6263   -1601     
- Partials     133     141      +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks again!

There's a test failure to fix on Windows and then it's good to go.

@peergum
Copy link

peergum commented Sep 9, 2024

@didiercrunch Thanks for this. I was working on creating an orange pi variation for H616, and I just found your PR.

I'm working on an Orange Pi Zero 2W, and your work may help me (at least to figure what else I should fix)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants