Migrate from CRA to Vite #20
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi Joakim! 👋 🙂 I have contemplated switching to Vite a few times but decided to put it further down on my todo. If you're interested in fixing the outstanding issues you mention above, I'd be 👍 for this change! |
|
Great! I took a quick look at the tests and it looks like there will be som work getting jest to run when using vite, maybe it would be better to migrate to vitest while we're at it? I don't really have an abundance of free time but I hope to get to it some evening ahead :) |
|
My github notifications is a mess, so saw this only now, sorry. But go for it! Haven't used vitest, but from the name it sounds like it makes sense if we're migrating to vite! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into a crash I had trouble getting a good stack trace and the source maps didn't point to the correct location. So I thought, wth, lets migrate this to Vite.
Right now this is just a draft. A few things needs to be fixed: