Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 1bp pool gas usage #85

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: 1bp pool gas usage #85

wants to merge 1 commit into from

Conversation

paco0x
Copy link
Contributor

@paco0x paco0x commented Apr 14, 2023

PR Reminders

Be ware of the followings

  • implement deployment script for your changes in deployment repo
  • add verification in hardhat simulation(000-prepare-simulation-check, 902-newMarket-check or 903-simulation-check) and system test(901-system-test) in deployment repo
  • update change log

  1. Contract: make sure the code follows our convention, ex: naming, explicit returns, etc.; if uncertain, discuss with others

  2. Test: make sure tests can cover most normal and edge cases; if not, open follow-up tickets. Also, look out for failed tests and fix them!

  3. CHANGELOG.md: update when external interfaces are changed

  4. Workflow:

    • Github: assign the pr to yourself; if pairing, can merge directly; else, assign someone to help review
    • Asana: assign the corresponding ticket to yourself and leave the pr link on it for easier follow-ups
    • Discord: if someone is mentioned in this pr, tag on Discord

eludius18
eludius18 reviewed Feb 12, 2024
View reviewed changes
test/clearingHouse/fixtures.ts
import { QuoteToken } from "../../typechain/QuoteToken"
import { TestAccountBalance } from "../../typechain/TestAccountBalance"
import { ChainlinkPriceFeedV2, ChainlinkPriceFeedV3, PriceFeedDispatcher } from "../../typechain/perp-oracle"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using Chainlink instead Pyth here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eludius18 eludius18 eludius18 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paco0x @eludius18