Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use classifiers to specify license #66

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

William-Wolke
Copy link
Contributor

Type of change

  • New feature
  • Bug fix
  • Security patch
  • Documentation update

Description

When this repo moved to using pyproject.toml it intoduced a bug for libraries like pip-licenses to properly determine the licese of this project. Since the file used to determine the license: license = { file = "./LICENSE" } is not standard due to extra text in front of the Copyright block

To fix this issue we can use classifiers to set the license for the package.

Motivation

This pr fixes issues for others using pip-licenses to check for licenses in their dependencies

Checklist

  • I have read the CONTRIBUTING document.
  • I have read and accepted the Code of conduct
  • Tests passes.
  • Style lints passes.
  • Documentation of new public methods exists.

@dannyhajj
Copy link
Member

Thanks for the fix!

@dannyhajj dannyhajj merged commit d99b7b0 into personnummer:master Feb 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants