Skip to content

Commit

Permalink
feat: php 8.4 support
Browse files Browse the repository at this point in the history
  • Loading branch information
nunomaduro committed Oct 15, 2024
1 parent 1513ede commit 6d9189f
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 20 deletions.
8 changes: 1 addition & 7 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,7 @@ jobs:
- name: Install PHP dependencies
shell: bash
run: |
if [[ "${{ matrix.php }}" == "8.4" ]]; then
composer update --${{ matrix.dependency_version }} --no-interaction --no-progress --ansi --with="symfony/console:^${{ matrix.symfony }}" --ignore-platform-req=php
else
composer update --${{ matrix.dependency_version }} --no-interaction --no-progress --ansi --with="symfony/console:^${{ matrix.symfony }}"
fi
run: composer update --${{ matrix.dependency_version }} --no-interaction --no-progress --ansi --with="symfony/console:^${{ matrix.symfony }}"

- name: Unit Tests
run: composer test:unit
Expand All @@ -51,5 +46,4 @@ jobs:
run: composer test:parallel

- name: Integration Tests
if: ${{ matrix.php != '8.4' }}
run: composer test:integration
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
],
"require": {
"php": "^8.2.0",
"brianium/paratest": "^7.5.7",
"brianium/paratest": "^7.6.0",
"nunomaduro/collision": "^8.4.0",
"nunomaduro/termwind": "^2.1.0",
"pestphp/pest-plugin": "^3.0.0",
Expand Down Expand Up @@ -52,7 +52,7 @@
]
},
"require-dev": {
"pestphp/pest-dev-tools": "^3.2.0",
"pestphp/pest-dev-tools": "^3.3.0",
"pestphp/pest-plugin-type-coverage": "^3.1.0",
"symfony/process": "^7.1.5"
},
Expand Down
9 changes: 0 additions & 9 deletions phpstan.neon
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
includes:
- vendor/phpstan/phpstan-strict-rules/rules.neon
- vendor/ergebnis/phpstan-rules/rules.neon
- vendor/thecodingmachine/phpstan-strict-rules/phpstan-strict-rules.neon

parameters:
Expand All @@ -12,12 +11,4 @@ parameters:
reportUnmatchedIgnoredErrors: true

ignoreErrors:
- "#has a nullable return type declaration.#"
- "#Language construct isset\\(\\) should not be used.#"
- "#is not allowed to extend#"
- "#is concrete, but does not have a Test suffix#"
- "#with a nullable type declaration#"
- "#type mixed is not subtype of native#"
- "# with null as default value#"
- "#has parameter \\$closure with default value.#"
- "#has parameter \\$description with default value.#"
2 changes: 1 addition & 1 deletion src/Factories/TestCaseFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ final class $className extends $baseClass implements $hasPrintableTestCaseClassF
}
PHP;

eval($classCode); // @phpstan-ignore-line
eval($classCode);
} catch (ParseError $caught) {
throw new RuntimeException(sprintf(
"Unable to create test case for test file at %s. \n %s",
Expand Down
2 changes: 1 addition & 1 deletion src/KernelDump.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public function enable(): void
*/
public function disable(): void
{
@ob_clean(); // @phpstan-ignore-line
@ob_clean();

if ($this->buffer !== '') {
$this->flush();
Expand Down

0 comments on commit 6d9189f

Please sign in to comment.