Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint 룰을 일부 수정합니다. #89

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

litsynp
Copy link
Contributor

@litsynp litsynp commented Aug 18, 2024

golangci-lint 룰을 일부 수정합니다.

  1. deprecated된 execinquery 린터를 제거합니다. 그냥 insert/update할 땐 Query 대신 Exec을 사용하면 됩니다.
internal/tests/config.go:7:1: directive `//nolint:gochecknoinits` is unused for linter "gochecknoinits" (nolintlint)
  1. gochecknoinits가 린터에서 init이라는 이름을 쓰는 것에 대해 임시로 처리합니다.

nolint를 걸어놨는데도 최근 들어 lint 에러가 뜨길래 봤더니 이름을 init으로 쓰고 있는 듯 합니다. 이슈를 보니 고쳐진 듯 하지만 임시로 제거합니다.

@litsynp litsynp added the chore Miscellaneous stuff label Aug 18, 2024
@litsynp litsynp requested a review from JoeCP17 August 18, 2024 02:07
@litsynp litsynp self-assigned this Aug 18, 2024
Copy link
Contributor

@JoeCP17 JoeCP17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 👍

@litsynp
Copy link
Contributor Author

litsynp commented Aug 19, 2024

🙇

@litsynp litsynp merged commit f1f6659 into main Aug 19, 2024
1 check passed
@litsynp litsynp deleted the fix/lint-rules branch August 19, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Miscellaneous stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants