Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.56.3 to ~> 1.57.0 #43

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 11, 2023

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.57

New features

  • #12227: Add new Style/SingleLineDoEndBlock cop. (@​koic)
  • #12246: Make Lint/RedundantSafeNavigation aware of constant receiver. (@​koic)
  • #12257: Make Style/RedundantDoubleSplatHashBraces aware of merge methods. (@​koic)

Bug fixes

  • #12244: Fix a false negative for Lint/Debugger when using debugger method inside block. (@​koic)
  • #12231: Fix a false negative for Metrics/ModuleLength when defining a singleton class in a module. (@​koic)
  • #12249: Fix a false positive Style/IdenticalConditionalBranches when if..else with identical leading lines and assign to condition value. (@​koic)
  • #12253: Fix Lint/LiteralInInterpolation to accept an empty string literal interpolated in words literal. (@​knu)
  • #12198: Fix an error for flip-flop with beginless or endless ranges. (@​koic)
  • #12259: Fix an error for Lint/MixedCaseRange when using nested character class in regexp. (@​koic)
  • #12237: Fix an error for Style/NestedTernaryOperator when a ternary operator has a nested ternary operator within an if. (@​koic)
  • #12228: Fix false negatives for Style/MultilineBlockChain when using multiline block chain with safe navigation operator. (@​koic)
  • #12247: Fix false negatives for Style/RedundantParentheses when using logical or comparison expressions with redundant parentheses. (@​koic)
  • #12226: Fix false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain. (@​koic)
  • #12076: Fixed an issue where the top-level cache folder was named differently during two consecutive rubocop runs. (@​K-S-A)

Changes

  • #12235: Enable auto parallel inspection when config file is specified. (@​aboutNisblee)
  • #12234: Enhance Style/FormatString's autocorrection when using known conversion methods whose return value is not an array. (@​koic)
  • #12128: Make Style/GuardClause aware of define_method. (@​koic)
  • #12126: Make Style/RedundantFilterChain aware of select.present? when ActiveSupportExtensionsEnabled config is true. (@​koic)
  • #12250: Mark Lint/RedundantRequireStatement as unsafe autocorrect. (@​koic)
  • #12097: Mark unsafe autocorrect for Style/ClassEqualityComparison. (@​koic)
  • #12210: Mark Style/RedundantFilterChain as unsafe autocorrect. (@​koic)
Changelog

Sourced from rubocop's changelog.

1.57.0 (2023-10-11)

New features

  • #12227: Add new Style/SingleLineDoEndBlock cop. ([@​koic][])
  • #12246: Make Lint/RedundantSafeNavigation aware of constant receiver. ([@​koic][])
  • #12257: Make Style/RedundantDoubleSplatHashBraces aware of merge methods. ([@​koic][])

Bug fixes

  • #12244: Fix a false negative for Lint/Debugger when using debugger method inside block. ([@​koic][])
  • #12231: Fix a false negative for Metrics/ModuleLength when defining a singleton class in a module. ([@​koic][])
  • #12249: Fix a false positive Style/IdenticalConditionalBranches when if..else with identical leading lines and assign to condition value. ([@​koic][])
  • #12253: Fix Lint/LiteralInInterpolation to accept an empty string literal interpolated in words literal. ([@​knu][])
  • #12198: Fix an error for flip-flop with beginless or endless ranges. ([@​koic][])
  • #12259: Fix an error for Lint/MixedCaseRange when using nested character class in regexp. ([@​koic][])
  • #12237: Fix an error for Style/NestedTernaryOperator when a ternary operator has a nested ternary operator within an if. ([@​koic][])
  • #12228: Fix false negatives for Style/MultilineBlockChain when using multiline block chain with safe navigation operator. ([@​koic][])
  • #12247: Fix false negatives for Style/RedundantParentheses when using logical or comparison expressions with redundant parentheses. ([@​koic][])
  • #12226: Fix false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain. ([@​koic][])
  • #12076: Fixed an issue where the top-level cache folder was named differently during two consecutive rubocop runs. ([@​K-S-A][])

Changes

  • #12235: Enable auto parallel inspection when config file is specified. ([@​aboutNisblee][])
  • #12234: Enhance Style/FormatString's autocorrection when using known conversion methods whose return value is not an array. ([@​koic][])
  • #12128: Make Style/GuardClause aware of define_method. ([@​koic][])
  • #12126: Make Style/RedundantFilterChain aware of select.present? when ActiveSupportExtensionsEnabled config is true. ([@​koic][])
  • #12250: Mark Lint/RedundantRequireStatement as unsafe autocorrect. ([@​koic][])
  • #12097: Mark unsafe autocorrect for Style/ClassEqualityComparison. ([@​koic][])
  • #12210: Mark Style/RedundantFilterChain as unsafe autocorrect. ([@​koic][])

1.56.4 (2023-09-28)

Bug fixes

  • #12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. ([@​koic][])
  • #12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. ([@​koic][])
  • #12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. ([@​koic][])
  • #12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. ([@​koic][])
  • #12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. ([@​koic][])
  • #12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. ([@​koic][])
  • #12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. ([@​ydah][])
  • #12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. ([@​koic][])

Changes

  • #12197: Make Style/CollectionMethods aware of collect_concat. ([@​koic][])

1.56.3 (2023-09-11)

... (truncated)

Commits
  • bfdb5ff Cut 1.57
  • 872d713 Update Changelog
  • 4025422 [Fix #12076] Explicitly require fileutils in RuboCop::Server::Cache
  • b4e2bdd [Fix #12259] Fix an error for Lint/MixedCaseRange
  • 986d047 Fix an error for Style/RedundantDoubleSplatHashBraces
  • 81ef51e [Fix #12257] Make Style/RedundantDoubleSplatHashBraces aware of merge
  • 86c0e8d [Fix #12249] Fix a false positive Style/IdenticalConditionalBranches
  • 6a100e6 Merge pull request #12255 from ydah/followup-12176
  • fb34152 Remove redundant true/false returns
  • 7b05f2a Merge pull request #12254 from joesiewert/empty-block-text
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.56.3...v1.57.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (83fce14) 99.88% compared to head (6199d86) 99.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          15       15           
  Lines        1726     1726           
=======================================
  Hits         1724     1724           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taichi-ishitani taichi-ishitani merged commit e3fa399 into master Oct 12, 2023
8 checks passed
@taichi-ishitani taichi-ishitani deleted the dependabot/bundler/rubocop-tw-1.57.0 branch October 12, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant