Track parent partition size when child partitions are untracked #656
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanlinsley
commented
Dec 19, 2024
| -- Only include sizes from child partitions skipped by ignore_schema_regexp. | ||
| -- Child partitions tracked by the collector have their sizes added by mergePartitionSizes. | ||
| AND ($1 != '' AND (n.nspname || '.' || t.relname) ~* $1) | ||
| ), 0) AS size_bytes, |
There was a problem hiding this comment.
The screenshot below is from local testing. 11:40 shows the detailed stats from #635. I then updated the collector config with ignore_schema_regexp = 35d_, and then 12:10 shows the updated behavior with this PR. Ignore the in-between timestamps where I was fixing bugs.
| // | ||
| // When ignore_schema_regexp is set, GetRelationStats bypasses this for tables not tracked by the collector. | ||
| // | ||
| // TODO: recursively build up stats when nested partitioning is used |
There was a problem hiding this comment.
This TODO is an existing issue with the code.
msakrejda
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#635 improved the fidelity of statistics tracked for parent partitions, but in moving the code from SQL to Go it stopped reporting the size of parent partitions when
ignore_schema_regexpis set to ignore the child partitions. This PR fixes #654 by bringing back the original SQL, but only applying it to child partitions that matchignore_schema_regexp.