Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accommodate POSTGRES_DB different from username but POSTGRES_INITDB_ARGS is not #23

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

jjb
Copy link
Member

@jjb jjb commented Mar 15, 2024

#20

@justinclift
Copy link
Member

Thanks, that makes sense. Does it fix the problem you were hitting in #7 (comment)?

@justinclift
Copy link
Member

I'll test this patch right now on my local workstation (takes about an hour), and if it passes ok then I'll merge this and push out updated Docker images with it. 😄

@jjb
Copy link
Member Author

jjb commented Mar 15, 2024

alas, did not work so far #20 (comment)

(sorry to spread this over 2 issues and a PR 😅 )

@justinclift
Copy link
Member

No worries. 😄

@justinclift
Copy link
Member

Testing this out again now, in addition to the patch that added support for PG 12.

From a rough eyeballing of this PR, it seems like it should work. Lets see how it goes in the actual build though... 😄


Should probably add some new tests too, specifically to create non-default database names.

Meh, that can be a later thing for a future PR... 😄

@justinclift justinclift merged commit ba99db1 into pgautoupgrade:main Mar 16, 2024
@justinclift
Copy link
Member

This is passing the tests, and looks useful, so has been merged. Thanks for getting this done @jjb. 😄

Updated Docker images are currently building, and will be on Docker Hub in the next hour or so.


The 12-dev image has been updated to include this PR and manually pushed to Docker Hub already, so you don't need to wait an hour. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants