Merge pull request #291 from pharmaR/cran_0.2.2

Cran 0.2.2
pharmaR · May 31, 2023 · 3d15018 · 3d15018
2 parents cf0b3b0 + a53c8c2
commit 3d15018
Show file tree

Hide file tree

Showing 59 changed files with 55 additions and 1,378 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -3,7 +3,7 @@ Type: Package
 Title: Risk Metrics to Evaluating R Packages
 Description: Facilities for assessing R packages against a number of metrics to 
     help quantify their robustness.
-Version: 0.2.1
+Version: 0.2.2
 Authors@R: c(
     person("R Validation Hub", role = c("aut"), email = "psi.aims.r.validation@gmail.com"),
     person("Doug", "Kelkhoff", role = c("aut"), email = "doug.kelkhoff@gmail.com"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# riskmetric 0.2.2
+
+- Fix bug with reporting number of downloads.
+
 # riskmetric 0.2.1
 
 - Updates for S3 Method consistancy for `vec_cast` and `pillar_shift` per CRAN 

diff --git a/R/pkg_ref_cache.R b/R/pkg_ref_cache.R
@@ -122,7 +122,8 @@ available_pkg_ref_fields <- function(x) {
 #' @family package reference cache
 #'
 #' @rdname riskmetric_metadata_caching
-#' @keywords internal
+#' @keyworks internal
+#' @noRd
 pkg_ref_cache <- function(x, name, ..., .class = as.character(name)) {
   UseMethod("pkg_ref_cache", structure(list(), class = .class))
 }
diff --git a/R/pkg_ref_cache_NEWS_urls.R b/R/pkg_ref_cache_NEWS_urls.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.news_urls <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.news_urls")
 }

diff --git a/R/pkg_ref_cache_archive_release_date.R b/R/pkg_ref_cache_archive_release_date.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.archive_release_dates <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.archive_release_dates")
 }

diff --git a/R/pkg_ref_cache_bug_reports.R b/R/pkg_ref_cache_bug_reports.R
@@ -4,12 +4,12 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.bug_reports <- function(x, ...) {
   UseMethod("pkg_ref_cache.bug_reports")
 }
 
 
-
 pkg_ref_cache.bug_reports.default <- function(x, ...) {
   scrape_bug_reports(x, ...)
 }

diff --git a/R/pkg_ref_cache_bug_reports_host.R b/R/pkg_ref_cache_bug_reports_host.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.bug_reports_host <- function(x, ...) {
   UseMethod("pkg_ref_cache.bug_reports_host")
 }

diff --git a/R/pkg_ref_cache_bug_reports_url.R b/R/pkg_ref_cache_bug_reports_url.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.bug_reports_url <- function(x, ...) {
   UseMethod("pkg_ref_cache.bug_reports_url")
 }

diff --git a/R/pkg_ref_cache_covr_coverage.R b/R/pkg_ref_cache_covr_coverage.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.covr_coverage <- function(x, ...) {
   UseMethod("pkg_ref_cache.covr_coverage")
 }

diff --git a/R/pkg_ref_cache_description.R b/R/pkg_ref_cache_description.R
@@ -1,9 +1,11 @@
 #' Cache the DESCRIPTION file contents for a package reference
 #'
+#'
 #' @inheritParams pkg_ref_cache
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.description <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.description")
 }

diff --git a/R/pkg_ref_cache_downloads.R b/R/pkg_ref_cache_downloads.R
@@ -7,6 +7,7 @@
 #' @importFrom cranlogs cran_downloads
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.downloads <- function(x, ..., n=365) {
   cran_downloads(x$name, from=Sys.Date()-n, to=Sys.Date())
 }
diff --git a/R/pkg_ref_cache_examples.R b/R/pkg_ref_cache_examples.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.examples <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.examples")
 }

diff --git a/R/pkg_ref_cache_expr_coverage.R b/R/pkg_ref_cache_expr_coverage.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.expression_coverage <- function(x, ...) {
   UseMethod("pkg_ref_cache.expr_coverage")
 }

diff --git a/R/pkg_ref_cache_help.R b/R/pkg_ref_cache_help.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.help <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.help")
 }

diff --git a/R/pkg_ref_cache_help_aliases.R b/R/pkg_ref_cache_help_aliases.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.help_aliases <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.help_aliases")
 }

diff --git a/R/pkg_ref_cache_license.R b/R/pkg_ref_cache_license.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.license <- function(x, ...) {
   UseMethod("pkg_ref_cache.license")
 }

diff --git a/R/pkg_ref_cache_maintainer.R b/R/pkg_ref_cache_maintainer.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.maintainer <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.maintainer")
 }

diff --git a/R/pkg_ref_cache_news.R b/R/pkg_ref_cache_news.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.news <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.news")
 }

diff --git a/R/pkg_ref_cache_r_cmd_check.R b/R/pkg_ref_cache_r_cmd_check.R
@@ -4,8 +4,8 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
-pkg_ref_cache.r_cmd_check <- function (x, ...)
-{
+#' @noRd
+pkg_ref_cache.r_cmd_check <- function(x, ...) {
   UseMethod("pkg_ref_cache.r_cmd_check")
 }
 
@@ -18,6 +18,7 @@ pkg_ref_cache.r_cmd_check.default <- function (x, ...) {
 #' @inheritParams pkg_ref_cache
 #' @importFrom devtools check
 #' @return a \code{pkg_ref} object
+#' @noRd
 pkg_ref_cache.r_cmd_check.pkg_source <- function(x, ...){
   check_results <- devtools::check(x$path, quiet=TRUE)
   return(check_results)

diff --git a/R/pkg_ref_cache_release_date.R b/R/pkg_ref_cache_release_date.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.release_date <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.release_date")
 }

diff --git a/R/pkg_ref_cache_remote_checks.R b/R/pkg_ref_cache_remote_checks.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.remote_checks <- function (x, ...) {
    UseMethod("pkg_ref_cache.remote_checks")
 }
@@ -31,7 +32,7 @@ pkg_ref_cache.remote_checks.pkg_cran_remote <- function(x, ...) {
 pkg_ref_cache.remote_checks.pkg_bioc_remote <- function(x, ...) {
   webURL <- sprintf("%s/%s", x$repo_base_url, x$name)
 
-  # TODO: 
+  # TODO:
   # refine x$repo_base_url for BioConductor packages so that we don't need to do
   # nasty substitutions like this
   webURL <- sub("packages/release/bioc[^/]*", "checkResults/release/bioc-LATEST", webURL)

diff --git a/R/pkg_ref_cache_repo_base_url.R b/R/pkg_ref_cache_repo_base_url.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.repo_base_url <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.repo_base_url")
 }

diff --git a/R/pkg_ref_cache_source_control_url.R b/R/pkg_ref_cache_source_control_url.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.source_control_url <- function(x, name, ...) {
   grep(
     "(github\\.com|bitbucket\\.org|gitlab\\.com)",

diff --git a/R/pkg_ref_cache_tarball_url.R b/R/pkg_ref_cache_tarball_url.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.tarball_url <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.tarball_url")
 }

diff --git a/R/pkg_ref_cache_vignettes.R b/R/pkg_ref_cache_vignettes.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.vignettes <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.vignettes")
 }

diff --git a/R/pkg_ref_cache_web_html.R b/R/pkg_ref_cache_web_html.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.web_html <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.web_html")
 }

diff --git a/R/pkg_ref_cache_web_url.R b/R/pkg_ref_cache_web_url.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.web_url <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.web_url")
 }

diff --git a/R/pkg_ref_cache_website_urls.R b/R/pkg_ref_cache_website_urls.R
@@ -4,6 +4,7 @@
 #' @family package reference cache
 #' @return a \code{pkg_ref} object
 #' @keywords internal
+#' @noRd
 pkg_ref_cache.website_urls <- function(x, name, ...) {
   UseMethod("pkg_ref_cache.website_urls")
 }

diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 # riskmetric <a href='https://pharmar.github.io/riskmetric/'><img src="man/figures/hex-riskmetric-aspconfig.png" align="right" height="172" style="float:right; height:172px;"/></a>
 
 [![R build status](https://github.com/pharmaR/riskmetric/workflows/R-CMD-check/badge.svg)](https://github.com/pharmaR/riskmetric/actions?workflow=R-CMD-check)
-[![Coverage status](https://codecov.io/gh/pharmaR/riskmetric/branch/master/graph/badge.svg)](https://codecov.io/github/pharmaR/riskmetric?branch=master)
+[![Coverage status](https://app.codecov.io/github/pharmaR/riskmetric?branch=master)
 
 `riskmetric` is a collection of risk metrics to evaluate the quality of R
 packages.

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,42 +1,13 @@
-## Submission 2
+## riskmetric 0.2.2
 
-Per comments from Gregor Seyer, the use of installed.packages was replaced with find.package. Examples for unexported functions were also removed.
-
-## Test environments
-* local R installation, R 3.6.2
-* local R installation, R 3.6.2
-* R hub: Windows Server 2022, R-devel, 64 bit
-* R hub: Ubuntu Linux 20.04.1 LTS, R-release, GCC
-* R hub: Fedora Linux, R-devel, clang, gfortran
-* GH Action: MacOS-latest
-* GH Action: Windows-latest
-* GH Action: Windows-latest(3.6)
-
-## 0.1.2 Release
-
-Please note the change in maintainer is documented [here](https://github.com/pharmaR/riskmetric/pull/228#issuecomment-1007753581) and [here](https://github.com/pharmaR/riskmetric/issues/227#issuecomment-1016703961).
-
-The note  about issues in the tmp directory appear only on the RHub windows machine and seems to be specific to that workflow.
-
-Previous archival was due to examples pulling from an API unexpectedly, theses have been fixed.
+- Bug fixes
+- Fixes issue with S3 method consistancy. 
 
+Tested on Ubuntu Jammy, GitHub Action, and RHub.
 
 ## R CMD check results
 
-0 errors | 0 warnings | 2 notes
-
-NOTES:
-* checking CRAN incoming feasibility ... NOTE
-Maintainer: 'Doug Kelkhoff <doug.kelkhoff@gmail.com>'
-
+0 errors | 0 warnings | 0 notes
 
-New submission
-Package was archived on CRAN
 
-CRAN repository db overrides:
-  X-CRAN-Comment: Archived on 2021-08-17 as repeated check problems
-    were not corrected in time.
-* checking for detritus in the temp directory ... NOTE
-Found the following files/directories:
-  'lastMiKTeXException'
 
diff --git a/man/pkg_assess.Rd b/man/pkg_assess.Rd