Update for new maintainer. Skip tests on cran update docs to not run …

…by default.
pharmaR · Jan 19, 2022 · 9a69408 · 9a69408
1 parent 9bc3102
commit 9a69408
Show file tree

Hide file tree

Showing 33 changed files with 91 additions and 36 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -6,9 +6,9 @@ Description: Facilities for assessing R packages against a number of metrics to
 Version: 0.1.2
 Authors@R: c(
     person("R Validation Hub", role = c("aut"), email = "psi.aims.r.validation@gmail.com"),
-    person("Doug", "Kelkhoff", role = c("aut", "cre"), email = "doug.kelkhoff@gmail.com"),
+    person("Doug", "Kelkhoff", role = c("aut"), email = "doug.kelkhoff@gmail.com"),
     person("Marly", "Gotti", role = c("aut")), 
-    person("Eli", "Miller", role = c("aut")), 
+    person("Eli", "Miller", role = c("cre", "aut"), email = "eli.miller@atorusresearch.com"), 
     person("Kevin", "K", role = c("aut")), 
     person("Yilong", "Zhang", role = c("aut")),
     person("Eric", "Milliman", role = c("aut")),

diff --git a/R/pkg_assess.R b/R/pkg_assess.R
@@ -20,7 +20,7 @@
 #' @keywords internal
 roxygen_assess_family <- function(name,
     return_type = "an atomic assessment result",
-    dontrun = FALSE) {
+    dontrun = TRUE) {
 
   assess_func <- sprintf("assess_%s", name)
   score_func <- sprintf("metric_score.pkg_metric_%s", name)

diff --git a/R/pkg_ref_class.R b/R/pkg_ref_class.R
@@ -57,15 +57,14 @@
 #' @export
 #'
 #' @examples
-#'
+#' \dontrun{
 #' # riskmetric will check for installed packages by default
 #' ref_1 <- pkg_ref("utils")
 #' ref_1$source # returns 'pkg_install'
 #'
 #' # lib.loc can be used to specify a library for pkg_install
 #' ref_3 <- pkg_ref("utils", source = "pkg_install", lib.loc = .libPaths()[1])
 #'
-#' \dontrun{
 #' # You can also override this behavior with a source argument
 #' ref_2 <- pkg_ref("utils", source = "pkg_cran_remote")
 #' ref_2$source  # returns 'pkg_cran_remote'

diff --git a/R/pkg_score.R b/R/pkg_score.R
@@ -96,7 +96,7 @@ pkg_score.list_of_pkg_metric <- function(x, ...,
 #' #' @eval roxygen_score_family("has_news")
 #' }
 #' @keywords internal
-roxygen_score_family <- function(name, dontrun = FALSE) {
+roxygen_score_family <- function(name, dontrun = TRUE) {
 
   assess_func <- sprintf("assess_%s", name)
   score_func <- sprintf("metric_score.pkg_metric_%s", name)

diff --git a/R/summarize_scores.R b/R/summarize_scores.R
@@ -15,10 +15,7 @@
 #' \dontrun{
 #' library(dplyr)
 #' summarize_scores(pkg_score(pkg_assess(as_tibble(pkg_ref("riskmetric")))))
-#' }
 #'
-#' # or, using the cleaner dplyr syntax
-#' \dontrun{
 #' library(dplyr)
 #' pkg_ref("riskmetric") %>%
 #'   pkg_assess() %>%

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,14 +1,38 @@
 ## Test environments
-* local R installation, R 4.0.1
-* ubuntu 16.04 (on travis-ci), R 4.0.1
-* win-builder (devel)
+* local R installation, R 3.6.2
+* local R installation, R 3.6.2
+* R hub: Windows Server 2022, R-devel, 64 bit
+* R hub: Ubuntu Linux 20.04.1 LTS, R-release, GCC
+* R hub: Fedora Linux, R-devel, clang, gfortran
+* GH Action: MacOS-latest
+* GH Action: Windows-latest
+* GH Action: Windows-latest(3.6)
+
+## 0.1.2 Release
+
+Please note the change in maintainer is documented [here](https://github.com/pharmaR/riskmetric/pull/228#issuecomment-1007753581) and [here](https://github.com/pharmaR/riskmetric/issues/227#issuecomment-1016703961).
+
+The note  about issues in the tmp directory appear only on the RHub windows machine and seems to be specific to that workflow.
+
+Previous archival was due to examples pulling from an API unexpectedly, theses have been fixed.
+
 
 ## R CMD check results
 
-0 errors | 0 warnings | 0 note
+0 errors | 0 warnings | 2 notes
+
+NOTES:
+* checking CRAN incoming feasibility ... NOTE
+Maintainer: 'Doug Kelkhoff <doug.kelkhoff@gmail.com>'
+
+
+New submission
+Package was archived on CRAN
 
-## Response from last CRAN submission comments
+CRAN repository db overrides:
+  X-CRAN-Comment: Archived on 2021-08-17 as repeated check problems
+    were not corrected in time.
+* checking for detritus in the temp directory ... NOTE
+Found the following files/directories:
+  'lastMiKTeXException'
 
-- There is no existing references describing the methods in this package. 
-- Added return \value item to Rd
-- Removed examples of unexported functions. 
diff --git a/man/assess_export_help.Rd b/man/assess_export_help.Rd
diff --git a/man/assess_exported_namespace.Rd b/man/assess_exported_namespace.Rd
diff --git a/man/assess_has_bug_reports_url.Rd b/man/assess_has_bug_reports_url.Rd
diff --git a/man/assess_has_maintainer.Rd b/man/assess_has_maintainer.Rd
diff --git a/man/assess_has_news.Rd b/man/assess_has_news.Rd
diff --git a/man/assess_has_source_control.Rd b/man/assess_has_source_control.Rd
diff --git a/man/assess_has_vignettes.Rd b/man/assess_has_vignettes.Rd
diff --git a/man/assess_has_website.Rd b/man/assess_has_website.Rd
diff --git a/man/assess_license.Rd b/man/assess_license.Rd
diff --git a/man/assess_news_current.Rd b/man/assess_news_current.Rd
diff --git a/man/firstS3method.Rd b/man/firstS3method.Rd
diff --git a/man/metric_score.pkg_metric_downloads_1yr.Rd b/man/metric_score.pkg_metric_downloads_1yr.Rd
diff --git a/man/metric_score.pkg_metric_export_help.Rd b/man/metric_score.pkg_metric_export_help.Rd
diff --git a/man/metric_score.pkg_metric_exported_namespace.Rd b/man/metric_score.pkg_metric_exported_namespace.Rd
diff --git a/man/metric_score.pkg_metric_has_bug_reports_url.Rd b/man/metric_score.pkg_metric_has_bug_reports_url.Rd
diff --git a/man/metric_score.pkg_metric_has_maintainer.Rd b/man/metric_score.pkg_metric_has_maintainer.Rd
diff --git a/man/metric_score.pkg_metric_has_news.Rd b/man/metric_score.pkg_metric_has_news.Rd
diff --git a/man/metric_score.pkg_metric_has_source_control.Rd b/man/metric_score.pkg_metric_has_source_control.Rd
diff --git a/man/metric_score.pkg_metric_has_vignettes.Rd b/man/metric_score.pkg_metric_has_vignettes.Rd
diff --git a/man/metric_score.pkg_metric_has_website.Rd b/man/metric_score.pkg_metric_has_website.Rd
diff --git a/man/metric_score.pkg_metric_license.Rd b/man/metric_score.pkg_metric_license.Rd
diff --git a/man/metric_score.pkg_metric_news_current.Rd b/man/metric_score.pkg_metric_news_current.Rd
diff --git a/man/pkg_ref.Rd b/man/pkg_ref.Rd
diff --git a/man/roxygen_assess_family.Rd b/man/roxygen_assess_family.Rd
diff --git a/man/roxygen_score_family.Rd b/man/roxygen_score_family.Rd
diff --git a/man/summarize_scores.Rd b/man/summarize_scores.Rd