-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to parse previous text log file #166
Conversation
… into 162_parse_log
Looks like one of the ubuntu failed checks are |
Looks like the Ubuntu 3.6 image is also failing for this one now. |
@parmsam-pfizer add yourself to the Description File!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking more on the purpose of this update. We are trying to extract and parse the contents of the to do some sort of analysis.
read_log_file
might be a bit misleading...what about extract_log_contents
, parse_log_contents
or something else??
The function is based on the name scheme used in readr. Maybe we can discuss alternate names at our next meeting. I'll work on the other edits in the meantime. |
@nicholas-masel @bms63 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @nicholas-masel or @kodesiba any last words?!?
Thank you for your Pull Request!
We have developed a Pull Request template to aid you and our reviewers. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the logrx codebase remains robust and consistent.
The spirit of logrx
While many packages to facilitate the logging of code already exist in the R ecosystem, it is hard to find a solution that works well for clinical programming applications. Many logging implementations are more implicit and rely on user input to create the log for the execution of a script. While this is useful for logging specific events of an application, in clinical programming a log has a set purpose.
logrx is built around the concept of creating a log for the execution of an R script that provides an overview of what happened as well as the environment that it happened in. We set out to create a flexible logging utility that could provide the necessary information to anyone reviewing the code execution so they can recreate the execution environment and run the code for themselves. Please make sure your Pull Request meets this spirit of logrx.
Please check off each taskbox as an acknowledgment that you completed the task. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
dev
branch until you have checked off each task.log_remove()
.devtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelypkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.R CMD check
locally and address all errors and warnings -devtools::check()
Adds `read_log_file() to read previous log object into list of tibbles object that you can more easily subset/filter. Addresses the first part of #162. Fixes #162.