Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow analysis to continue even after the first test error #56

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

DurieuxPol
Copy link
Collaborator

Add an option to allow all the tests to be executed on mutants, even after the first error or fail.
Default behavior does not change.

@coveralls
Copy link

coveralls commented Dec 20, 2023

Pull Request Test Coverage Report for Build 7289076931

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 84 of 92 (91.3%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 60.394%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/MuTalk-Model/MutationTestingAnalysis.class.st 14 18 77.78%
src/MuTalk-TestResources/AuxiliarTestClassForContinuingTestsExecutionAfterFirstFail.class.st 27 31 87.1%
Totals Coverage Status
Change from base Build 7225461317: 0.3%
Covered Lines: 3864
Relevant Lines: 6398

💛 - Coveralls

DurieuxPol and others added 4 commits December 20, 2023 16:17
Excluding a failing test class used only to test an option in Mutalk
Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci @DurieuxPol and @Inao0!
Thanks for the feature. And for the test 🥲!

Would it be possible to quickly fix the duplicated code so I integrate this afternoon?

src/MuTalk-Model/MutantEvaluation.class.st Show resolved Hide resolved
src/MuTalk-Model/MethodMutation.class.st Show resolved Hide resolved
src/MuTalk-Model/MethodMutation.class.st Show resolved Hide resolved
@DurieuxPol
Copy link
Collaborator Author

Did some refactoring following @guillep's change request.

Copy link
Contributor

@guillep guillep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@guillep guillep merged commit 8f4acf8 into pharo-contributions:master Dec 21, 2023
3 checks passed
@DurieuxPol DurieuxPol deleted the enh/runAllTests branch February 5, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants