remove bigquery dependency on Recordset

[phenobarbital]

Summary by Sourcery

Remove the direct dependency on BigQuery in the Recordset class by using a more generic attribute check, and update the library version to 2.7.18.

Enhancements:

• Remove direct dependency on BigQuery in Recordset by using a more generic attribute check.

Chores:

• Bump version number from 2.7.17 to 2.7.18.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the direct dependency on BigQuery in the Recordset class by replacing the type check with a more generic attribute check. Additionally, the library version has been incremented from 2.7.17 to 2.7.18.

File-Level Changes

Files	Changes
asyncdb/meta/recordset.py asyncdb/version.py	Removed the direct dependency on BigQuery in Recordset and updated the library version.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @phenobarbital - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider using a more generic attribute than 'job_id' for type checking, as this might be too specific to BigQuery.
• Please confirm that this change doesn't break existing behavior for code that may be relying on BigQuery-specific functionality.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion: Consider adding a comment explaining the rationale for using hasattr instead of isinstance

While this change makes the check more flexible, it would be helpful to explain why hasattr is preferred over isinstance in this case. This will aid future maintainers in understanding the decision.

Suggested change

	if hasattr(result, 'job_id'): # BigQuery Row Iterator
	# Check if result is a BigQuery RowIterator without relying on specific class
	# This allows for more flexibility with different BigQuery client versions
	if hasattr(result, 'job_id'): # BigQuery Row Iterator