Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature move current tab to an existing window #3925

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dyckia
Copy link

@dyckia dyckia commented Sep 28, 2021

Add feature move current tab to an existing window

Add a new command Vomnibar.moveTabToWindow which moves the current tab to an existing window.

Press key w which brings up the omnibar that displays a list of existing windows.

Once a window is selected, the current tab will be moved to the end position in the selected window, and focus is automatically switched to that tab.

  • Suggestions only display the windows that have the same state (normal/incognito).
  • Suggestions will automatically hide the window the tab is currently in.

@developomp
Copy link

can this PR be merged?

@philc
Copy link
Owner

philc commented Jul 23, 2023

Hey @dyckia, sorry for the delay.

This seems like a reasonable feature and the implementation looks good. But for completeness, can you describe some of your use cases where you need this command?

Second, the code base has changed quite a bit recently and this will need to be reworked a bit to work again.

Third, there are some unrelated changes (the addition of closeOneTabOnLeft and other commands, scrollPageUp magnitude) which should be removed.

@philc philc added the waiting label Jul 23, 2023
@IdoKendo
Copy link

IdoKendo commented Feb 6, 2024

Hi @philc @dyckia I am also interested in this feature quite a bit. If this PR is not panning out I would be willing to try and implement it myself, if it's fine by you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants