Add command to show link URL without opening it #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You may want to see the URL of a link before you open it with `f`/`F`. This change introduces a new `LinkHints.activateModeToShowLinkUrl` mode, bound to `sf` by default, that lets you choose a link on the page, and will show the corresponding URL in the HUD.
ehdr
commented
Jan 24, 2022
| if (link.href != null) { | ||
| let url = link.href; | ||
| if (url.slice(0, 7) === "mailto:") { url = url.slice(7); } | ||
| if (28 < url.length) { url = url.slice(0, 23) + "...."; } |
There was a problem hiding this comment.
It's unfortunate that it seems the HUD can't display long messages (see screenshot), and thus must truncate long URLs, which partly defeats the purpose of this feature (which is to review the link URL before you follow it). Is there a way around this?
|
Why this is not merged yet? LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
You may want to see the URL of a link before you open it with
f/F, e.g. to make sure it's not malicious. This change introduces a newLinkHints.activateModeToShowLinkUrlmode, bound tosfby default, that lets you choose a link on the page, and will show the corresponding URL in the HUD.