Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time highlighting of the search results #4010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yousfiSaad
Copy link

Description

This is an implementation of the Incremental search and highlights features.
Issues talking about this feature are : #3469 , #591 , #3100

@gdh1995
Copy link
Contributor

gdh1995 commented Feb 15, 2022

As said in #3469 (comment), this PR creates new DOM elements to add styles to matched text, but this behavior may break some pages .

I suggest that we may use element.getBoundingClientRect() and create many <div style="left:...;top:...;width:...;height:..."> to show bounding boxes (without background color), like what Ctrl+Shift+J/K do in my Vimium C (https://github.com/gdh1995/vimium-c).

@chrisgrieser
Copy link

I'd love to have the feature merged into vimium 🙏

@MathiasSven
Copy link

As others have expressed, even if the implementation as it currently is might break in some pages, the benefits of the feature might outweigh the potential issues, what would be the harm in having this as an optional experimental feature under the advanced options with a disclamer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants