Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user-configurable search completion providers #4283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rileywilddog
Copy link
Contributor

Search completions are clearly useful enough to be a mainline feature, but the maintainer does not want to expand its usefulness by adding more providers. This PR allows users to benefit from the feature with more than the handful of built-in completion providers.

Adds the following tested examples:

rs: https://runescape.wiki/?search=%s @https://runescape.wiki/api.php?action=opensearch&format=json&search=%s Runescape Wiki
os: https://oldschool.runescape.wiki/?search=%s @https://oldschool.runescape.wiki/api.php?action=opensearch&format=json&search=%s Old School Runescape wiki
man: https://www.mankier.com/?q=%s @https://www.mankier.com/api/v2/suggest/?q=%s@results.*.text ManKier Man Pages

Fixes #4281, opened in case this PR is also rejected.
Mitigates the following closed or ignored PRs/issues to add engines:
#3851 #3981 #4091 #4094 #4189 #4238

@micangl
Copy link

micangl commented Oct 12, 2023

@philc is there a chance for this PR to be merged before the next release? Currently, the only way to have custom search completion is by patching the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Custom search completion providers
2 participants