Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moonmaster36 patch 1 #4495

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

moonmaster36
Copy link

Rationale

  • Current Installing From Source instructions were a little outdated.
  • Made instructions more clear by adding screenshots
  • Made instructions more clear by making it easy to copy/paste command line arguments.

Corresponding Issue

Updated image links to point to screenshots/
Final changes before submitting pull request
@philc
Copy link
Owner

philc commented Jun 12, 2024

Hey @moonmaster36, thanks for putting in the effort to make these instructions clearer. However, I think this is an unnecessarily high level of handholding, and the screenshot approach doesn't age well as the browser UIs slowly evolve. My understanding is that most people install the extension from the stores, and those who want to install from source are able to figure out from the current instructions, including how to check out the repo from Github.

@moonmaster36
Copy link
Author

moonmaster36 commented Jun 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants