Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new hint style #4504

Closed
wants to merge 1 commit into from
Closed

new hint style #4504

wants to merge 1 commit into from

Conversation

m13v
Copy link

@m13v m13v commented Jun 22, 2024

Description

I find bright yellow hint buttons to be too large, and a bit too colorful. I've changed the padding and background color to white. Check out the demo of how it looks like:
https://www.linkedin.com/posts/matthew-diakonov-a84a1911_browsing-through-the-web-with-keyboard-shortcuts-activity-7210104293620686848-EeyU?utm_source=share&utm_medium=member_desktop

Please review the "Which pull requests get merged?" section in CONTRIBUTING.md.

@JUSTIVE
Copy link

JUSTIVE commented Jun 29, 2024

I like the current style more than this PRs. Those style-related issues may be controversial. But having a theme option and more options would be great.

@UncleSnail
Copy link
Contributor

@m13v Users can change the styles themselves in the settings if they would like (press "?", then "Options" and add your custom CSS to "CSS for Vimium UI"). That is the recommended way to make Vimium look how you would like. It seems to me that there is no need to change the default styling to white with more padding since it is personal preference and the yellow links stand out more. This PR might not fit well with the contribution guidelines and you can consider closing it if you think it appropriate.

@philc
Copy link
Owner

philc commented Aug 5, 2024

We'll stick with the current style, but thank you @m13v for posting your implementation for an alternate hint style.

@philc philc closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants