Implement Inspect protocol for HTMLTree #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vittoriabitton
force-pushed
the
vb-implement-inspect-to-htmltree
branch
2 times, most recently
from
c0c20d1
to
ce4cf2f
Compare
vittoriabitton
force-pushed
the
vb-implement-inspect-to-htmltree
branch
from
f849b0b
to
3a0eb98
Compare
vittoriabitton
force-pushed
the
vb-implement-inspect-to-htmltree
branch
from
5109def
to
43b7829
Compare
vittoriabitton
changed the title
philss
reviewed
Mar 14, 2024
test/floki/html_tree_test.exs
Outdated
Comment on lines
261
to
268
| html_tree = %HTMLTree{ | ||
| root_nodes_ids: [2, 1], | ||
| node_ids: [2, 1], | ||
| nodes: %{ | ||
| 1 => %Text{content: "hello", node_id: 1}, | ||
| 2 => %Text{content: " world", node_id: 2} | ||
| } | ||
| } |
There was a problem hiding this comment.
After thinking for a while, I believe the parser won't produce such tree, because the Text would be collapsed. So I would change this to one Text` node, or maybe adding a tag in between.
test/floki/html_tree_test.exs
Outdated
| } | ||
|
|
||
| assert inspect(html_tree) == | ||
| ~s|%HTMLTree{<html>start of the stack<a class="link"><b>click me</b></a><span></span></html>}| |
There was a problem hiding this comment.
We forgot to format the comment. The suggestions I made is changing that. But the output here will be different.
PS: try to add a |> dbg() to line 292 and see the beauty of the output :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.