Use json from Erlang/OTP 27 #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanderhoop
reviewed
Jun 6, 2024
There was a problem hiding this comment.
This change would force consumers of flame to be on OTP 27, and Elixir 1.17 as a result, which I don't think is desired at this time.
See michalmuskala/jason#185 for more info
josevalim
reviewed
Jul 15, 2024
lib/flame/parser/json.ex
Outdated
| @@ -0,0 +1,29 @@ | |||
| defmodule FLAME.Parser.JSON do | |||
| @moduledoc """ | |||
There was a problem hiding this comment.
This module should be private.
josevalim
reviewed
Jul 15, 2024
lib/flame/parser/json.ex
Outdated
| "{\"a\":1,\"b\":2}" | ||
| """ | ||
| @spec encode!(any) :: iodata() | ||
| def encode!(data) do |
There was a problem hiding this comment.
We should check if System.otp_release() >= "27", if so, we can use :json, otherwise we need to use Jason and we add Jason as an optional dependency.
josevalim
reviewed
Jul 15, 2024
.tool-versions
Outdated
| @@ -0,0 +1,2 @@ | |||
| erlang 27.0 | |||
| elixir 1.17.0-rc.1-otp-27 | |||
There was a problem hiding this comment.
We should work with older OTP versions accordingly, so we should remove this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
:jsonparser from erlang OTP 27