Add documentation on using presence with LiveView #5577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 29, 2023
guides/real_time/presence.md
Outdated
| ``` | ||
|
|
||
| Then we can navigate to http://localhost:4000/online/Alice in one tab, and http://localhost:4000/online/Bob in another, you'll see that the presences are tracked, along with the number of presences per user. Opening and closing tabs with various users will update the presence list in real-time. | ||
|
|
||
| ## Making it safe |
There was a problem hiding this comment.
Should we make this a subsection of the channel one?
There was a problem hiding this comment.
This is the channels one? Do you mean should we make the content match and just change the URLs?
phoenix/guides/real_time/presence.md
Line 118 in d33f7bd
josevalim
approved these changes
Sep 29, 2023
jordelver
reviewed
Sep 29, 2023
guides/real_time/presence.md
Outdated
|
|
||
| Whilst Phoenix does ship with a JavaScript API for dealing with presence, it is also possible to extend the `HelloWeb.Presence` module to support LiveView. | ||
|
|
||
| One think to keep in mind when dealing with LiveView, is that each LiveView is a stateful process, so if we keep the oresebce state in the LiveView, each LiveView process will contain the full list of online users in memory. Instead, we can keep track of the online users within the `Presence` process, and pass separate events to the LiveView, which can use a stream to update the online list. |
There was a problem hiding this comment.
Suggested change
| One think to keep in mind when dealing with LiveView, is that each LiveView is a stateful process, so if we keep the oresebce state in the LiveView, each LiveView process will contain the full list of online users in memory. Instead, we can keep track of the online users within the `Presence` process, and pass separate events to the LiveView, which can use a stream to update the online list. | |
| One think to keep in mind when dealing with LiveView, is that each LiveView is a stateful process, so if we keep the presence state in the LiveView, each LiveView process will contain the full list of online users in memory. Instead, we can keep track of the online users within the `Presence` process, and pass separate events to the LiveView, which can use a stream to update the online list. |
There was a problem hiding this comment.
Also, "one thing" instead of "one think"!
Gazler
force-pushed
the
docs/live-view-presence
branch
from
d33f7bd to
a265f43
Compare
The presence guide has been split into two sections, the existing one is now usage with Channels and JavaScript. The new section if the guide is focused on LiveView and outlines creating an Elixir based presence client, and using a LiveView stream for rendering the list of online users.
Gazler
force-pushed
the
docs/live-view-presence
branch
from
a265f43 to
283d91b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence guide has been split into two sections, the existing one is now usage with Channels and JavaScript.
The new section if the guide is focused on LiveView and outlines creating an Elixir based presence client, and using a LiveView stream for rendering the list of online users.
This closes #4858