PHP 8 Support for decimal 2.x #54
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build log and tests for me locally are build and tests |
|
Arginfo could be generated https://externals.io/message/105970 Example nikic/php-ast@15a7ebd |
|
Aarch64 and s390x bit different failures https://gitlab.alpinelinux.org/andypost/aports/-/pipelines/62997 (32-bits arches are broken before) |
|
There's existing stub https://github.com/JetBrains/phpstorm-stubs/blob/master/decimal/decimal.php |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP on
ZEND_TYPE_ENCODE_CLASS_CONSTtoZEND_TYPE_INIT_CLASS_CONSTlooks it needs one more condition to 80000 php/php-src@ac4e0f0Z_PARAM_STRICT_LONGtoZ_PARAM_LONG- implementation in 8.x are the same, but needs checking php/php-src@8a0965eRef #43 (comment)