Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI tests in php 8.3 in CI #1344

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

amenophis
Copy link

Hi,
This PR allows to run the CI on php 8.3

@amenophis
Copy link
Author

@makasim Could you please authorize the workflow run to see the state of tests 🙏

@amenophis
Copy link
Author

@makasim Thanks for merging the other PR, could you restart the CI please ?

@amenophis
Copy link
Author

Hi @makasim
It seems the php 8.3 images added by makasim/docker-nginx-php-fpm#9 are not available on the docker registry.
Did you build and push them ?

Thanks 🙏

@makasim
Copy link
Member

makasim commented Apr 5, 2024

Nope, but I'll try on weekends. (feel free to ping me the next week).

@amenophis
Copy link
Author

Hi @makasim
Since the image for php 8.3 was just built, could you restart the CI on this branch ?

Thanks 🙏

@makasim
Copy link
Member

makasim commented Apr 8, 2024

btw, you can drop too old versions if they fail ( do not spent time fixing them).

@makasim
Copy link
Member

makasim commented Apr 8, 2024

symfony 5.4\6.3 and php 8.4 would be enough

@amenophis
Copy link
Author

@makasim I did some fixes in the CI, and restrict version to PHP 8.2/8.3 and Symfony 5.5/6.4 for now.

Can you restart the CI please ?
🙏

@amenophis
Copy link
Author

Hi @makasim
It seems that failed tests are flaky, so could you please retry them ?

Is it normal that it donesn't automatically start on new commit ?

Thanks 🙏

@amenophis
Copy link
Author

Hi @makasim
Could you retry last CI run ?

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants