Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psr17: prevet usage of deprecated StreamFactory and use StreamFactoryInterface instead #87

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

glaubinix
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? yes
Related tickets fixes #85, finishes #86
Documentation if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation
License MIT

What's in this PR?

Finishes PR #86

Why?

Avoids installing the deprecated package php-http/message-factory

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

@glaubinix glaubinix force-pushed the psr17 branch 2 times, most recently from 6d7b56f to 42a5886 Compare November 14, 2023 15:46
@dbu
Copy link
Contributor

dbu commented Nov 14, 2023

thanks a lot!

i created the 2.x branch now. i added a header in the changelog to separate version 1 and 2 in case we do some bugfixes in the 1.x branch.

@glaubinix glaubinix changed the base branch from 1.x to 2.x November 14, 2023 16:27
@glaubinix
Copy link
Contributor Author

glaubinix commented Nov 14, 2023

Rebased changes onto the 2.x branch. There is one reference of the StreamFactory in the docs that needs to be adjusted too. Will have a look at the docs repo later this week too.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@dbu dbu merged commit 3562529 into php-http:2.x Nov 15, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

php-http/message-factory is abandoned (deprecation error)
2 participants