Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for PHP 8.4 #87

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Add Support for PHP 8.4 #87

merged 5 commits into from
Oct 31, 2024

Conversation

gsteel
Copy link
Contributor

@gsteel gsteel commented Oct 30, 2024 •
edited
Loading

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Adds PHP 8.4 to the test matrix, explicitly marks nullable parameters as nullable.

Why?

Implicit nulls are deprecated on 8.4

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

dbu
dbu approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot! looks good, i will merge and tag a release.

CHANGELOG.md Outdated Show resolved Hide resolved
@dbu dbu merged commit f3eb48d into php-http:2.x Oct 31, 2024
8 checks passed
@gsteel gsteel deleted the php-8.4 branch October 31, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @dbu