Accept Throwable as rejection reason

php-http · Nov 25, 2023 · e80412d · e80412d
1 parent 7fa2284
commit e80412d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Change Log
 
+## 1.2.2
+
+### Fixed
+
+- Fix accepting `Throwable` as rejection reason of a promise
+
 ## 1.2.1
 
 ### Added

diff --git a/src/FulfilledPromise.php b/src/FulfilledPromise.php
@@ -37,8 +37,8 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
 
         try {
             return new self($onFulfilled($this->result));
-        } catch (\Exception $e) {
-            return new RejectedPromise($e);
+        } catch (\Throwable $exception) {
+            return new RejectedPromise($exception);
         }
     }
 

diff --git a/src/RejectedPromise.php b/src/RejectedPromise.php
@@ -14,11 +14,11 @@
 final class RejectedPromise implements Promise
 {
     /**
-     * @var \Exception
+     * @var \Throwable
      */
     private $exception;
 
-    public function __construct(\Exception $exception)
+    public function __construct(\Throwable $exception)
     {
         $this->exception = $exception;
     }
@@ -34,8 +34,8 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
 
         try {
             return new FulfilledPromise($onRejected($this->exception));
-        } catch (\Exception $e) {
-            return new self($e);
+        } catch (\Throwable $exception) {
+            return new self($exception);
         }
     }