extend FloatingIP with description and subnet_id #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antondollmaier
force-pushed
the
floatingip
branch
from
3eb10b8 to
61cb6fe
Compare
k0ka
reviewed
Jan 5, 2025
k0ka
reviewed
Jan 5, 2025
k0ka
requested changes
Jan 5, 2025
There was a problem hiding this comment.
Hello, thank you for your contribution!
Please, fix integration tests and remove subnet_id from the model.
We can make sure the FloatingIp was created in the correct subnet by checking floatingIpAddress. But it's not that easy, so I guess we can just skip that test and make it undocumented.
antondollmaier
force-pushed
the
floatingip
branch
from
61cb6fe to
2cc7ab5
Compare
k0ka
requested changes
Jan 6, 2025
The OpenStack API for Floating IPs supports: - an optional description of the floating IP - specifying a specific subnet_id upon creation The subnet ID is not returned on GET.
antondollmaier
force-pushed
the
floatingip
branch
from
2cc7ab5 to
c6ff3d7
Compare
k0ka
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenStack API for Floating IPs supports:
an optional
descriptionof the floating IPoptionally specifying a specific
subnet_idupon creation of the floating IPThe subnet ID is not returned on GET.
This is my first time working with php-opencloud/openstack and my first pull request to this project. I have extended the unit tests to verify the description. I did not run the integration tests but verified the changes against our OpenStack environment.