New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frankenphp: break loop when loopMax is reached #174

Merged

alexander-schranz merged 1 commit into php-runtime:main from tamcy:main

Jun 14, 2024

Contributor

tamcy commented Jun 14, 2024

Fixes the issue that the loop doesn't exist when $loopMax is reached, but $loopMax+1. Please refer to #173 for details.


          frankenphp: break loop when loopMax is reached

a5bce1c

tamcy mentioned this pull request

frankenphp: fix loop increment and break behavior #173

Closed

dunglas approved these changes

View reviewed changes

alexander-schranz merged commit 1fae0b9 into php-runtime:main

11 checks passed

Member

alexander-schranz commented Jun 14, 2024

@tamcy Thank you for the contribution 👍 ! @dunglas Thx for the quick reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet