Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to INI mode constants #3136

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jan 23, 2024

Adds descriptions to each INI mode constant, copied from their PHP_INI aliases.

These are also on the missing constants list which I'm guessing is because these are in a table instead of a variablelist.

@haszi
Copy link
Contributor Author

haszi commented Jan 23, 2024

I took another look at the source code and it seems that the PHP_INI_* constants are not even exposed to userland so I removed these as aliases.

Unfortunately it gets worse than this. These non-existent constants are used 730 times in 88 doc files, mostly in the ini.xml files of just about every extension.

I could submit one PR with a huge number of changes but I'm not sure that would be welcome.

@Girgias
Copy link
Member

Girgias commented Jan 24, 2024

Aaaaaaaaaaaaaaaaaaaaaaaaa

Well this is... unfortunate. However, as those are easily machine fixable I think it should be done, but the commit should have a [skip-revcheck] tag and the same script should be applied to all translations. Might as well also add the missing <constant> tags if possible.

But this should be a separate PR.

reference/info/constants.xml Outdated Show resolved Hide resolved
@haszi haszi requested a review from Girgias January 24, 2024 18:18
@Girgias Girgias merged commit 05c845a into php:master Jan 25, 2024
2 checks passed
@haszi haszi deleted the Add-description-to-INI-mode-constants branch January 25, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants