Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor markup conformance issue in DateTime extension #3327

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Apr 21, 2024

Part of #3326, an <example> tag requires a <title>.

I couldn't come up with titles for the 3 examples, so I converted them to <informalexample> which don't have that requirement. @derickr if you have suggestions for titles to use instead, let me know.

@Girgias Girgias force-pushed the docbook5-markup-fixes branch 2 times, most recently from 8659665 to 2d42320 Compare April 21, 2024 22:45
@kamil-tekiela kamil-tekiela removed their request for review April 21, 2024 22:46
@Girgias Girgias force-pushed the docbook5-markup-fixes branch 2 times, most recently from f491bf0 to 1faa375 Compare April 21, 2024 23:06
@Girgias Girgias changed the title Various fixes in preparation for DocBook 5.2 schema migration Fix minor markup conformance issue in DateTime extension Apr 22, 2024
@Girgias Girgias requested a review from derickr April 22, 2024 12:56
Copy link
Member

@derickr derickr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, they don't really need a title.

@Girgias Girgias merged commit ac83abe into php:master Apr 22, 2024
2 checks passed
@Girgias Girgias deleted the docbook5-markup-fixes branch April 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants