Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LDAP constants #3513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add LDAP constants #3513

wants to merge 2 commits into from

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jun 29, 2024

I did not write any descriptions for the peer certificate checking and CRL evaluation strategy constants as I could not find any references discussing these in detail.

Peer certificate checking strategies:
LDAP_OPT_X_TLS_ALLOW
LDAP_OPT_X_TLS_DEMAND
LDAP_OPT_X_TLS_HARD
LDAP_OPT_X_TLS_NEVER
LDAP_OPT_X_TLS_TRY

CRL evaluation strategies:
LDAP_OPT_X_TLS_CRL_ALL
LDAP_OPT_X_TLS_CRL_NONE
LDAP_OPT_X_TLS_CRL_PEER

@devnexen devnexen requested a review from Girgias July 5, 2024 11:45
@Girgias
Copy link
Member

Girgias commented Jul 7, 2024

Maybe @MCMic can provide some desriptions?

@haszi
Copy link
Contributor Author

haszi commented Jul 8, 2024

I've found this page where it is suggested that the TLS_REQCERT (and presumably the TLS_CRLCHECK) sections of this manpage are what we're looking for here. Unfortunately I don't know enough about LDAP to be sure.

@Girgias
Copy link
Member

Girgias commented Jul 9, 2024

I'll wait a bit longer, if @MCMic doesn't reply we'll merge as is.

@haszi
Copy link
Contributor Author

haszi commented Jul 28, 2024

I've read up some more on LDAP and added the descriptions for peer certificate and CRL evaluation strategies.

References:

  • client (TLS_REQCERT and TLS_CRLCHECK)
  • server (TLSVerifyClient and TLSCRLCheck)

@kocsismate
Copy link
Member

kocsismate commented Aug 1, 2024

@Girgias Do you think we can merge it now? If all LDAP constants are going to be documented then only ~170 globals constants remain undocumented (on global constant pages at least). That's brilliant work! 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants