Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add earlier hint about array_column supporting objects #3546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Seldaek
Copy link
Contributor

@Seldaek Seldaek commented Jul 11, 2024

I know it says below in the parameter description, but tbh I didn't read that far before I assumed this only worked for arrays :D

@cmb69
Copy link
Member

cmb69 commented Jul 11, 2024

As a user, reading the current documentation, I might wonder what a "column of an array" is (after all, there are no real multidimensional arrays in PHP). While the description of the array parameter clarifies that, the function description just repeats that "column of an array". Maybe that section should be updated to clarify what is meant by that, instead of changing the refpurpose (which is supposed to be as short as possible).

@Seldaek
Copy link
Contributor Author

Seldaek commented Jul 11, 2024

Yeah I am not sure how to best describe all these things in a consistent way per the docs, but this reads fairly confusing I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants