Add deprecation message for libxml_disable_entity_loader

Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
php · Jul 8, 2024 · d5af2de · d5af2de
1 parent d3a7a69
commit d5af2de
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/ext/libxml/libxml.stub.php b/ext/libxml/libxml.stub.php
@@ -179,7 +179,7 @@ function libxml_get_errors(): array {}
 
 function libxml_clear_errors(): void {}
 
-#[\Deprecated(since: '8.0')]
+#[\Deprecated(message: 'as external entity loading is disabled by default', since: '8.0')]
 function libxml_disable_entity_loader(bool $disable = true): bool {}
 
 function libxml_set_external_entity_loader(?callable $resolver_function): bool {}

diff --git a/ext/libxml/libxml_arginfo.h b/ext/libxml/libxml_arginfo.h
diff --git a/ext/libxml/tests/libxml_disable_entity_loader.phpt b/ext/libxml/tests/libxml_disable_entity_loader.phpt
@@ -37,7 +37,7 @@ echo "Done\n";
 --EXPECTF--
 bool(true)
 
-Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0 in %s on line %d
+Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0, as external entity loading is disabled by default in %s on line %d
 bool(false)
 
 Warning: DOMDocument::loadXML(): I/O warning : failed to load external entity "%s" in %s on line %d

diff --git a/ext/libxml/tests/libxml_disable_entity_loader_2.phpt b/ext/libxml/tests/libxml_disable_entity_loader_2.phpt
@@ -37,7 +37,7 @@ echo "Done\n";
 --EXPECTF--
 bool(true)
 
-Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0 in %s on line %d
+Deprecated: Function libxml_disable_entity_loader() is deprecated since 8.0, as external entity loading is disabled by default in %s on line %d
 bool(false)
 
 Warning: DOMDocument::loadXML(): %Sfailed to load external entity "%s" in %s on line %d