RFC: Deprecate date_sunrise and date_sunset constants #12978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I do think it makes sense to add this to the 8.4 mass deprecation RFC, feel free to edit that RFC directly by adding a new section :) |
jorgsowa
changed the title
|
Great. I added it to the list, and removed from this PR part about ini settings as those are already deprecated in older RFC. |
TimWolla
changed the title
|
What's the reason for deprecating this? |
|
These constants are exclusively used by the date_sunset() and date_sunrise() which are already deprecated, so after removal, there will be no reasonable use for those constants. |
jorgsowa
force-pushed
the
deprecate_date_sunrise_constants
branch
from
a26c561
to
bee7d42
Compare
derickr
approved these changes
May 22, 2024
TimWolla
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the PR previously tackling the problem of deprecation of constants related to the functions
date_sunriseanddate_sunsetwas abandoned I want to tackle this problem again.This PR deprecates the constants used exclusively by functions date_sunset() and date_sunrise():
Do you think it could be included in the PHP 8.4 Deprecations RFC?