Generic pack() test for 64-bit
#14014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP-8.2: [ci skip] NEWS Fix incorrect check in fpm_shm_free() (php#13797)
* PHP-8.3: [ci skip] NEWS Fix incorrect check in fpm_shm_free() (php#13797)
* PHP-8.2: [ci skip] Adjust GC threshold if num_roots is higher than gc_threshold after collection (php#13758)
* PHP-8.3: [ci skip] [ci skip] Adjust GC threshold if num_roots is higher than gc_threshold after collection (php#13758)
* PHP-8.2: Tests are not repeatable
* PHP-8.3: Tests are not repeatable
* PHP-8.2: PHP-8.2 is now for PHP 8.2.19-dev
* PHP-8.3: PHP-8.2 is now for PHP 8.2.19-dev
…sing opcache.preload This regressed in 9a250cc, which allowed static properties to get overridden by a trait during inheritance. In particular, because of the change to the loop in zend_update_parent_ce(), it's not guaranteed that all indirects are after one another. This means that during persisting the zvals of the static members table, some static properties may be skipped. In case of the test code, this means that the array in the trait will keep referring to the old, new freed, stale value. To solve this, we check the type for IS_INDIRECT, which is the same as what zend_persist_calc() is already doing anyway. Since 2543e61 we can check for IS_INDIRECT to see if it should be persisted or not. Closes phpGH-13794.
* PHP-8.3: Fix phpGH-13433: Segmentation Fault in zend_class_init_statics when using opcache.preload
This adds all root build directories in one call. PEAR directory is created only when enabled and duplicated Zend directory creation is removed, because it was intended for the zend_config.h when building out-of-source or using the config.status manually before the PHP_ADD_BUILD_DIR was introduced in the build system.
Useful to control how many SYN packets the client will send to the server before giving up establishing a connection if the server does not respond (usually 5 or 6 by default). Close phpGH-13816
…ilable for Thread Local Storage. Close phpGH-13832
github-actions
bot
added
Extension: enchant
Extension: exif
Extension: ffi
Extension: fileinfo
Extension: filter
Extension: ftp
Extension: gd
Extension: gettext
Extension: gmp
Extension: hash
Extension: iconv
Extension: imap
Extension: json
Extension: ldap
Extension: libxml
Extension: mbstring
Extension: mysqli
Category: Optimizer
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: I'm sorry for all the irrelevant commits and pings. Please ignore this.
Generic
pack()test for 64-bit.Also add some test cases for better coverage.
Add headers to generic pack test:
To make the output easier to read.
Add generic pack test for 64bit:
Split int size-dependent test cases.
Add missing test cases for generic pack() test:
Add tests for uncovered lines. (For one uncovered part, I'd like to make a code fix later day...)
Locally the coverage increased as follows with the third commit on master: