Autotools: Refactor dmalloc check

[petk]

• AC_SEARCH_LIBS automatically appends the library to the LIBS
• AS_VAR_APPEND used for enabling Dmalloc check-funcs token
• CS synced

[devnexen]

seems looking ok, are you planning further changes ?

[petk]

seems looking ok, are you planning further changes ?

Yes, sorry, I've opened this one too soon. Because AC_SEARCH_LIBS is for libraries that might be also in C library.

[petk]

So, now I've added the AC_CHECK_LIB back and synced only CS. AC_CHECK_LIB is better for this. Some other M4 macros also add the -g flag but I won't sync this yet here. Perhaps in the future.

Also this dmalloc functionality currently still has one more pending fix #8465 because the headers need to be slightly moved around. Some symbols stuff and I have no idea why it happens yet. Fixing this in that PR is better. There might be even a simpler patch:

diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c
index e84defb3da..77026cd878 100644
--- a/sapi/cli/php_cli_server.c
+++ b/sapi/cli/php_cli_server.c
@@ -15,6 +15,8 @@
    +----------------------------------------------------------------------+
 */
 
+#include "php.h"
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <fcntl.h>
@@ -59,7 +61,6 @@
 #endif
 
 #include "SAPI.h"
-#include "php.h"
 #include "php_ini.h"
 #include "php_main.h"
 #include "php_globals.h"