Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotools: Refactor ext/standard libcrypt algos cache variables #14791

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petk
Copy link
Member

@petk petk commented Jul 3, 2024

  • CS synced a bit
  • Over-quoted arguments reduced
  • New single cache variable php_cv_lib_crypt_algos=yes|no that can
    control whether the crypt library includes the required algorithms.
    It can be used in cross-compilation when building with external crypt
    library.

@petk
Copy link
Member Author

petk commented Jul 3, 2024

I've just remembered to change something here more. Basically all these algorithms when checking external libcrypt could be wrapped in a single AC_CACHE_CHECK and cross-compilation is a bit simpler. Coming up in the next commit.

@petk petk marked this pull request as draft July 3, 2024 16:34
@petk petk force-pushed the patch-cache-variables-standard branch from 8ec3b76 to 63892ab Compare July 10, 2024 23:00
@petk petk changed the title Autotools: Refactor ext/standard cache variables Autotools: Refactor ext/standard libcrypt algos cache variables Jul 10, 2024
@petk petk marked this pull request as ready for review July 10, 2024 23:01
@petk petk marked this pull request as draft July 10, 2024 23:43
- CS synced a bit
- Over-quoted arguments reduced
- New single cache variable php_cv_lib_crypt_algos=yes|no that can
  control whether the crypt library includes the required algorithms.
  It can be used in cross-compilation when building with external crypt
  library.
- Autoconf and shell syntax works on Autoconf 2.68+
@petk petk force-pushed the patch-cache-variables-standard branch from cc1c734 to 334cf9f Compare July 11, 2024 17:56
@petk petk marked this pull request as ready for review July 11, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant