GH-14930: Revert "Reserve less file space if possible in a directory entry" #14933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug ticket claims that this affects PHP 8.3, so this PR should probably target the |
Hi @cmb69 The bug was introduced in PHP 8.3, but it affects the master branch as well. |
Bug fixes should always go against the lowest supported branch the bug is in. So this should indeed target PHP-8.3. |
|
TIL. Let me update the PR. Cheers! |
joec4i
force-pushed
the
revert-dir-name-len-change
branch
from
78d62b2
to
987ee94
Compare
nielsdos
approved these changes
Jul 12, 2024
|
Merged into 8.3 and up, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts 00c1e7b from #11577 which fixes #14930 .