Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: Deprecate session.sid_length and session.sid_bits_per_character #15213

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Aug 3, 2024

@@ -11,13 +11,13 @@ ob_start();

echo "*** Testing session_id() : basic functionality ***\n";

ini_set('session.sid_bits_per_chracter', 6);
ini_set('session.sid_bits_per_character', 6);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was extra fun: Changing the INI was not even tested in practice.

@TimWolla TimWolla added the RFC label Aug 3, 2024
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimWolla TimWolla merged commit e8ff7c7 into php:master Aug 4, 2024
8 of 11 checks passed
@TimWolla TimWolla deleted the deprecate-session-id-format-ini branch August 4, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants