Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotools: Add ext/readline preprocessor macros help texts #15241

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

petk
Copy link
Member

@petk petk commented Aug 5, 2024

This adds the missing macros help texts for easier understanding. The AC_DEFINE can be called with only 2 arguments if there is another definition in the code where template (see AH_TEMPLATE Autoconf macro) is read by autoheader (the 2nd AC_DEFINE sets the template for all other definitions with the same name).

This is done like this and taking into consideration also that readline library part of the config.m4 file will be removed in the near future due to license mismatch.

This adds the missing macros help texts for easier understanding. The
AC_DEFINE can be called with only 2 arguments if there is another
definition in the code where template (see AH_TEMPLATE Autoconf macro)
is read by autoheader (the 2nd AC_DEFINE sets the template for all other
definitions with the same name).
ext/readline/config.m4 Outdated Show resolved Hide resolved
@petk petk merged commit da5362c into php:master Aug 6, 2024
1 of 2 checks passed
@petk petk deleted the patch-AC_DEFINE-readline branch August 6, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants