zend_enum: Rename try parameter to avoid conflict with C++ #15259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`try` is a keyword in C++, and as such C++ code including <zend_enum.h> fails to compile unless a workaround is in place. To resolve this, we simply rename the parameter. We choose `try_from` to make it clear that this parameter is true when the function is called from `BackedEnum::tryFrom()`. For consistency, we also rename the `try` parameter of `zend_enum_from_base()`, although that function is not exported.
|
Maybe give credits to @oplanre :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tryis a keyword in C++, and as such C++ code including <zend_enum.h> fails to compile unless a workaround is in place. To resolve this, we simply rename the parameter.We choose
try_fromto make it clear that this parameter is true when the function is called fromBackedEnum::tryFrom(). For consistency, we also rename thetryparameter ofzend_enum_from_base(), although that function is not exported.Note that this is a follow-up on #15235, which has been closed for unknown reasons, but has been a valid request.