Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/mysqlnd: Use zval_try_get_string() instead of converting zval #15264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Aug 6, 2024

No description provided.

@Girgias Girgias marked this pull request as ready for review August 7, 2024 00:43
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, although I am not sure what difference does it make here.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong because the string is never freed it will leak memory for non-interned strings.
Probably should do an in-place "try" convert instead of getting a separate string?
Note that row data is managed by mysqlnd so that will destroy the zval

@devnexen
Copy link
Member

devnexen commented Aug 9, 2024

she knows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants