Remove platform requirement #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requirement might exist to prevent contributors from committing something incompatible with the lowest supported version of PHP to the lock file, thus breaking the "locked" jobs.
greg0ire
force-pushed
the
remove-platform-requirement
branch
from
dfc68a3
to
d20b131
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requirement might exist to prevent contributors from committing something incompatible with the lowest supported version of PHP to the lock file, thus breaking the "locked" jobs.
Here is a proof that it works: https://github.com/phpDocumentor/guides/actions/runs/7370041293/job/20055989129?pr=793#step:6:105
Note that
composer config --unset platformis fine to run when when the config option does not exist, so this should not break projects that do not have the option if any.