Cleanup stubs [skip ci]

phpv8 · May 1, 2017 · 64ec8a5 · 64ec8a5
1 parent e54baec
commit 64ec8a5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 25 deletions.
diff --git a/stubs/src/MapObject.php b/stubs/src/MapObject.php
@@ -33,8 +33,6 @@ public function Clear()
      * @param Context $context
      * @param Value   $key
      *
-     * //TODO: add throws
-     *
      * @return Value
      */
     public function Get(Context $context, Value $key): Value
@@ -46,8 +44,6 @@ public function Get(Context $context, Value $key): Value
      * @param Value   $key
      * @param Value   $value
      *
-     * //TODO: add throws
-     *
      * @return MapObject
      */
     public function Set(Context $context, Value $key, Value $value): MapObject

diff --git a/stubs/src/Script.php b/stubs/src/Script.php
@@ -16,7 +16,9 @@
 
 class Script
 {
-    //private $isolate;
+    /**
+     * @var Context
+     */
     private $context;
 
     /**
@@ -26,7 +28,6 @@ class Script
      */
     public function __construct(Context $context, StringValue $source, ScriptOrigin $origin = null)
     {
-        // $this->isolate = $context->isolate;
         $this->context = $context;
     }
 

diff --git a/stubs/src/Template.php b/stubs/src/Template.php
@@ -52,12 +52,6 @@ public function Set(NameValue $name, /*Data*/ $value, int $attributes = Property
     {
     }
 
-    //public function void SetAccessorProperty(
-    //      Local<Name> name,
-    //   Local<FunctionTemplate> getter = Local<FunctionTemplate>(),
-    //   Local<FunctionTemplate> setter = Local<FunctionTemplate>(),
-    //   PropertyAttribute attribute = None,
-    //   AccessControl settings = DEFAULT);
     /**
      * @param NameValue            $name
      * @param \V8\FunctionTemplate $getter
@@ -103,20 +97,8 @@ public function SetNativeDataProperty(
         callable $getter,
         callable $setter = null,
         $attribute = PropertyAttribute::None,
-        FunctionTemplate $receiver,
+        FunctionTemplate $receiver = null,
         $settings = AccessControl::DEFAULT_ACCESS
     ) {
     }
-
-    //public function void SetNativeDataProperty(Local<Name> name,
-    //                           AccessorNameGetterCallback getter,
-    //                           AccessorNameSetterCallback setter = 0,
-    //                           // TODO(dcarney): gcc can't handle Local below
-    //                           Handle<Value> data = Handle<Value>(),
-    //                           PropertyAttribute attribute = None,
-    //                           Local<AccessorSignature> signature =
-    //      Local<AccessorSignature>(),
-    //                           AccessControl settings = DEFAULT);
-
-
 }