New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Validate email #252

Open

LukaszSwierzewski wants to merge 1 commit into phuocng:master from LukaszSwierzewski:patch-1

LukaszSwierzewski commented May 21, 2020

Check user email


          Create Validate email

28adcf4

Check user email

Contributor

robinpokorny commented Jun 19, 2020

Hey Lukasz, thanks for your PR!

I see two issues with the code. First, it is not 1LOC 😂 And second, validating email is really hard, even this RegExp would fail on some valid addresses. See https://haacked.com/archive/2007/08/21/i-knew-how-to-validate-an-email-address-until-i.aspx/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet