format relative time #321
Open
format relative time #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good work @walebant, better than using the famous package "moment" ! |
WiXSL
suggested changes
Dec 13, 2021
| unit - Unit to use in the relative time internationalized message. | ||
| Possible values are: "year", "quarter", "month", "week", "day", "hour", "minute", "second". | ||
| Plural forms are also permitted. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| */ | |
| locale - String representing the locale to be used. Defaults to "en" | |
| */ |
There was a problem hiding this comment.
It would be great if the local could be passed as an optional parameter.
| @@ -0,0 +1,15 @@ | |||
| ```javascript | |||
| const rtf = (value, unit) => new Intl.RelativeTimeFormat('en').format(value, unit); | |||
There was a problem hiding this comment.
Suggested change
| const rtf = (value, unit) => new Intl.RelativeTimeFormat('en').format(value, unit); | |
| const rtf = (value, unit, locale = 'en') => new Intl.RelativeTimeFormat(locale).format(value, unit); |
| // Example | ||
| rtf(5, 'day'); // in 5 days | ||
| rtf(-3, 'day'); // 3 days ago | ||
| rtf(2, 'minutes'); // in 2 min |
There was a problem hiding this comment.
Suggested change
| rtf(2, 'minutes'); // in 2 min | |
| rtf(2, 'minutes'); // in 2 min | |
| rtf(2, 'minutes', 'es'); // dentro de 2 minutos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Intl.RelativeTimeFormat constructor, we can format relative time in a locale-sensitive manner with ease. This lets us format relative time strings without the hassle that comes from manipulating strings.